[llvm-commits] [llvm] r106038 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp test/CodeGen/Generic/v-binop-widen.ll test/CodeGen/Generic/v-binop-widen2.ll

[Visa Putkinen]

On Wed, Jun 16, 2010 at 02:16:50PM -0700, Jakob Stoklund Olesen wrote:
> On Jun 16, 2010, at 2:09 PM, Jim Grosbach wrote:
> > I changed the test to use "< %s" in r106146 so it'll stop polluting the test source directoy. I don't know what FileCheck entries should also be there, though.

Thanks, Jim. I'll use "< %s" in the future.

> Many tests pass simply by not crashing llc. I am guessing that is the case here.

That is indeed the case here.

> If the test case can crash llc without needing fancy options, multiple tests can be collected in one file, see test/CodeGen/X86/crash.ll.

Good to know. In that case v-binop-widen.ll should be moved into a
crash.ll (or be removed altogether). The test was supposed to demo a
crash in X86 target caused by a bug in common CodeGen code. So should
such tests be under test/CodeGen/X86 or test/CodeGen/Generic?

 - Visa