[llvm-commits] [llvm] r106038 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp test/CodeGen/Generic/v-binop-widen.ll test/CodeGen/Generic/v-binop-widen2.ll

[Jim Grosbach]

On Jun 16, 2010, at 2:16 PM, Jakob Stoklund Olesen wrote:

> 
> On Jun 16, 2010, at 2:09 PM, Jim Grosbach wrote:
> 
>> I changed the test to use "< %s" in r106146 so it'll stop polluting the test source directoy. I don't know what FileCheck entries should also be there, though.
> 
> Many tests pass simply by not crashing llc. I am guessing that is the case here.
> 
> If the test case can crash llc without needing fancy options, multiple tests can be collected in one file, see test/CodeGen/X86/crash.ll.
> 

That's a good point and entirely reasonable. If that's the case here, just adding a comment to that effect in the file or moving the test to crash.ll instead of in its own .ll file should clear up potential future confusion.