[llvm-commits] [llvm] r106038 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp test/CodeGen/Generic/v-binop-widen.ll test/CodeGen/Generic/v-binop-widen2.ll

[Jakob Stoklund Olesen]

On Jun 17, 2010, at 7:17 AM, Visa Putkinen wrote:

> On Wed, Jun 16, 2010 at 02:16:50PM -0700, Jakob Stoklund Olesen wrote:
>> On Jun 16, 2010, at 2:09 PM, Jim Grosbach wrote:
>>> I changed the test to use "< %s" in r106146 so it'll stop polluting the test source directoy. I don't know what FileCheck entries should also be there, though.
> 
> Thanks, Jim. I'll use "< %s" in the future.
> 
>> Many tests pass simply by not crashing llc. I am guessing that is the case here.
> 
> That is indeed the case here.
> 
>> If the test case can crash llc without needing fancy options, multiple tests can be collected in one file, see test/CodeGen/X86/crash.ll.
> 
> Good to know. In that case v-binop-widen.ll should be moved into a
> crash.ll (or be removed altogether). The test was supposed to demo a
> crash in X86 target caused by a bug in common CodeGen code. So should
> such tests be under test/CodeGen/X86 or test/CodeGen/Generic?

If it requires the X86 target, it should go in the X86 directory.

The X86 target may not be present when running the Generic tests.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100617/4eba55b1/attachment.bin>