[llvm-commits] Create DebugLocs even without DwarfWriter

[Chris Lattner]

On May 1, 2009, at 12:25 PM, Argiris Kirtzidis wrote:

> The attached patch:
>
> -Moves the DwarfWriter::ValidDebugInfo check to a static  
> DIDescriptor::ValidDebugInfo
> -Creates DebugLocs without the need to have a DwarfWriter around
>
> This is another tiny step towards the "get DwarfWriter out of  
> instruction selectors" direction.


Looks great to me, some things that aren't your fault:  :)

1. can getGlobalVariable use Value::stripPointerCasts?

+    /// FIXME. This interfers with the qualitfy of generated code when
+    /// during optimization.

typo: qualitfy

Thanks for working on this Argiris!

-Chris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090502/b180aae8/attachment.html>