<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On May 1, 2009, at 12:25 PM, Argiris Kirtzidis wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>The attached patch:<br><br>-Moves the DwarfWriter::ValidDebugInfo check to a static DIDescriptor::ValidDebugInfo<br>-Creates DebugLocs without the need to have a DwarfWriter around<br><br>This is another tiny step towards the "get DwarfWriter out of instruction selectors" direction.<br></div></blockquote></div><div><br></div><div>Looks great to me, some things that aren't your fault: :)</div><div><br></div><div>1. can <span class="Apple-style-span" style="font-family: Monaco; font-size: 10px; ">getGlobalVariable use Value::<span class="Apple-style-span" style="font-family: Helvetica; font-size: 12px; ">stripPointerCasts?</span></span></div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">+ /// FIXME. This interfers with the qualitfy of generated code when</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">+ /// during optimization.</div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"><br></span></font></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;">typo: qualitfy</span></font></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"><br></span></font></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;">Thanks for working on this Argiris!</span></font></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"><br></span></font></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;">-Chris</span></font></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"><br></span></font></div></div></body></html>