[llvm-commits] Create DebugLocs even without DwarfWriter

[Argiris Kirtzidis]

Chris Lattner wrote:
>
> On May 1, 2009, at 12:25 PM, Argiris Kirtzidis wrote:
>
>> The attached patch:
>>
>> -Moves the DwarfWriter::ValidDebugInfo check to a static 
>> DIDescriptor::ValidDebugInfo
>> -Creates DebugLocs without the need to have a DwarfWriter around
>>
>> This is another tiny step towards the "get DwarfWriter out of 
>> instruction selectors" direction.
>
> Looks great to me, some things that aren't your fault:  :)
>
> 1. can getGlobalVariable use Value::stripPointerCasts?

Ok, replaced the use of getGlobalVariable with stripPointerCasts.

>
> +    /// FIXME. This interfers with the qualitfy of generated code when
> +    /// during optimization.
>
> typo: qualitfy

Done.

Commited:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090427/076991.html

Thanks for reviewing!

-Argiris