[llvm-commits] PR1146 patch for llvm-gcc-4.0
rspencer at reidspencer.com
Sat Aug 18 23:13:57 PDT 2007
On Thu, 2007-08-16 at 16:32 +0200, Duncan Sands wrote:
> Hi Reid,
> in ConvertFunctionType:
> > + PAL = 0;
> so there is no need for callers to set PAL = 0 before
> calling ConvertFunctionType, as they all do right now.
> For that matter, it's not clear that this assignment is
> needed since it looks like PAL is always assigned
> elsewhere before ConvertFunctionType returns (you could
> argue that initializing it to zero is defensive programming,
> defending against future changes).
That is exactly the reason why it is initialized.
More information about the llvm-commits