[llvm-commits] PR1146 patch for llvm-gcc-4.0

Duncan Sands baldrick at free.fr
Thu Aug 16 07:32:46 PDT 2007


Hi Reid,

in ConvertFunctionType:

> +  PAL = 0;

so there is no need for callers to set PAL = 0 before
calling ConvertFunctionType, as they all do right now.
For that matter, it's not clear that this assignment is
needed since it looks like PAL is always assigned
elsewhere before ConvertFunctionType returns (you could
argue that initializing it to zero is defensive programming,
defending against future changes).

Ciao,

Duncan.



More information about the llvm-commits mailing list