[llvm-commits] PR1146 patch for llvm-gcc-4.0

Duncan Sands baldrick at free.fr
Thu Aug 16 08:56:07 PDT 2007

Hi Reid,

> -      Attrs.push_back(ParamAttrsWithIndex::get(ArgTypes.size(), Attributes));
> +      Client.addAttributes(ArgTypes.size(), Attributes);

all users of addAttributes seem to be adding a new attribute at
the back.  Given this, your implementation of addAttributes looks
inefficient.  Also, does it work correctly? - addAttributes doesn't
add the attribute at all if there are no existing attributes for that
index, which seems to be exactly the case for every use of it!



More information about the llvm-commits mailing list