[llvm-commits] PR1146 patch for llvm-gcc-4.0

Reid Spencer rspencer at reidspencer.com
Sat Aug 18 23:14:56 PDT 2007

On Thu, 2007-08-16 at 17:56 +0200, Duncan Sands wrote:
> Hi Reid,
> > -      Attrs.push_back(ParamAttrsWithIndex::get(ArgTypes.size(), Attributes));
> > +      Client.addAttributes(ArgTypes.size(), Attributes);
> all users of addAttributes seem to be adding a new attribute at
> the back.  Given this, your implementation of addAttributes looks
> inefficient.  Also, does it work correctly? - addAttributes doesn't
> add the attribute at all if there are no existing attributes for that
> index, which seems to be exactly the case for every use of it!

Again, this doesn't exist in the current patch. Please see the patch
currently attached to PR1146 for the latest details. Thanks for taking a
look at this though, I appreciate it.


> Ciao,
> Duncan.

More information about the llvm-commits mailing list