[llvm-bugs] [Bug 51944] New: llvm-rc: not merging string literals in ICON type

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=51944

            Bug ID: 51944
           Summary: llvm-rc: not merging string literals in ICON type
           Product: new-bugs
           Version: 12.0
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: llvm-bugzilla at jdrake.com
                CC: htmldeveloper at gmail.com, llvm-bugs at lists.llvm.org,
                    martin at martin.st

I'm not really sure if this is something that only works in windres or if it
also works in rc.exe.  I came across this rc in virt-viewer

  llvm-rc: Error in ICON statement (ID 2): 
  Is a directory
'['D:/a/_temp/msys/msys64/clang64/bin/windres.EXE',
'-DICONDIR=\\"C:/_/mingw-w64-virt-viewer/src/build-x86_64-w64-mingw32/icons\\"',
'-DMANIFESTDIR=\\"C:/_/mingw-w64-virt-viewer/src/virt-viewer-10.0/src\\"',
'-i', 'src/virt-viewer.rc', '-o', 'src/virt-viewer-rc.o']' returned non-zero
exit status 1.

The RC file in question is
https://gitlab.com/virt-viewer/virt-viewer/-/blob/v10.0/src/virt-viewer.rc.in ,
and the ICON statement is

2 ICON ICONDIR "/virt-viewer.ico"

I assume they meant for that to somehow transform into `2 ICON
"C:/_/mingw-w64-virt-viewer/src/build-x86_64-w64-mingw32/icons/virt-viewer.ico"`.
 This reminded me of https://reviews.llvm.org/D105621#inline-1004064 but this
is in an ICON statement not a user defined resource.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210922/1ccd8ae3/attachment.html>