<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - llvm-rc: not merging string literals in ICON type"
href="https://bugs.llvm.org/show_bug.cgi?id=51944">51944</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>llvm-rc: not merging string literals in ICON type
</td>
</tr>
<tr>
<th>Product</th>
<td>new-bugs
</td>
</tr>
<tr>
<th>Version</th>
<td>12.0
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Windows NT
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>new bugs
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>llvm-bugzilla@jdrake.com
</td>
</tr>
<tr>
<th>CC</th>
<td>htmldeveloper@gmail.com, llvm-bugs@lists.llvm.org, martin@martin.st
</td>
</tr></table>
<p>
<div>
<pre>I'm not really sure if this is something that only works in windres or if it
also works in rc.exe. I came across this rc in virt-viewer
llvm-rc: Error in ICON statement (ID 2):
Is a directory
'['D:/a/_temp/msys/msys64/clang64/bin/windres.EXE',
'-DICONDIR=\\"C:/_/mingw-w64-virt-viewer/src/build-x86_64-w64-mingw32/icons\\"',
'-DMANIFESTDIR=\\"C:/_/mingw-w64-virt-viewer/src/virt-viewer-10.0/src\\"',
'-i', 'src/virt-viewer.rc', '-o', 'src/virt-viewer-rc.o']' returned non-zero
exit status 1.
The RC file in question is
<a href="https://gitlab.com/virt-viewer/virt-viewer/-/blob/v10.0/src/virt-viewer.rc.in">https://gitlab.com/virt-viewer/virt-viewer/-/blob/v10.0/src/virt-viewer.rc.in</a> ,
and the ICON statement is
2 ICON ICONDIR "/virt-viewer.ico"
I assume they meant for that to somehow transform into `2 ICON
"C:/_/mingw-w64-virt-viewer/src/build-x86_64-w64-mingw32/icons/virt-viewer.ico"`.
This reminded me of <a href="https://reviews.llvm.org/D105621#inline-1004064">https://reviews.llvm.org/D105621#inline-1004064</a> but this
is in an ICON statement not a user defined resource.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>