[llvm-bugs] [Bug 49714] New: update_test_checks.py does not use FileCheck var for BB labels

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=49714

            Bug ID: 49714
           Summary: update_test_checks.py does not use FileCheck var for
                    BB labels
           Product: Test Suite
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: lit
          Assignee: unassignedbugs at nondot.org
          Reporter: thomas.preudhomme at celest.fr
                CC: daniel at zuster.org, llvm-bugs at lists.llvm.org

Hi,

update_test_checks.py uses variable for IR variables but do not use them for
basic block labels due to them not being preceded by the % symbol. The output
looks kind of weird with hardcoding of labels except when used in an
instruction.

Perhaps a first pass could be made over label to identify them (instead of
hardcoding knowledge of instructions that uses label) and use variable not
including the % prefix for those with a special naming scheme (e.g. BB_<FOO> or
<FOO>_BB).

An example of what I would expect instead of what is generated (see changes to
loopexitinglatch.ll testcase):

https://reviews.llvm.org/D99204#change-hTLptTksclfo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210324/1463e975/attachment-0001.html>