<html>
    <head>
      <base href="https://bugs.llvm.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - update_test_checks.py does not use FileCheck var for BB labels"
   href="https://bugs.llvm.org/show_bug.cgi?id=49714">49714</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>update_test_checks.py does not use FileCheck var for BB labels
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>Test Suite
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>trunk
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>PC
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>enhancement
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>lit
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>thomas.preudhomme@celest.fr
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>daniel@zuster.org, llvm-bugs@lists.llvm.org
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Hi,

update_test_checks.py uses variable for IR variables but do not use them for
basic block labels due to them not being preceded by the % symbol. The output
looks kind of weird with hardcoding of labels except when used in an
instruction.

Perhaps a first pass could be made over label to identify them (instead of
hardcoding knowledge of instructions that uses label) and use variable not
including the % prefix for those with a special naming scheme (e.g. BB_<FOO> or
<FOO>_BB).

An example of what I would expect instead of what is generated (see changes to
loopexitinglatch.ll testcase):

<a href="https://reviews.llvm.org/D99204#change-hTLptTksclfo">https://reviews.llvm.org/D99204#change-hTLptTksclfo</a></pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>