[llvm-bugs] [Bug 48689] Commit 21f7cf4057b7 causing huge regression in compile time

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=48689

Reid Kleckner <rnk at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED
                 CC|                            |rnk at google.com

--- Comment #5 from Reid Kleckner <rnk at google.com> ---
I don't think LLVM_DEBUG does what you want it to. I think you should consider
EXPENSIVE_CHECKS instead.

LLVM_DEBUG is defined here, conditional on NDEBUG, which is what controls
assertions, so LLVM_DEBUG will run in Release+Asserts builds:
https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/Support/Debug.h#L122

If I'm reading it correctly, LLVM_DEBUG only runs when the `-debug` LLVM option
is set, and debug output from the relevant pass is enabled. This option is
almost never enabled in the regular test suite, so with LLVM_DEBUG, this
verification function is almost never called.

See also the bug I filed about verifyFunction being too slow:
https://bugs.llvm.org/show_bug.cgi?id=47712

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210108/0af07264/attachment.html>