<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:rnk@google.com" title="Reid Kleckner <rnk@google.com>"> <span class="fn">Reid Kleckner</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Commit 21f7cf4057b7 causing huge regression in compile time"
href="https://bugs.llvm.org/show_bug.cgi?id=48689">bug 48689</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>FIXED
</td>
<td>---
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>RESOLVED
</td>
<td>REOPENED
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>rnk@google.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Commit 21f7cf4057b7 causing huge regression in compile time"
href="https://bugs.llvm.org/show_bug.cgi?id=48689#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Commit 21f7cf4057b7 causing huge regression in compile time"
href="https://bugs.llvm.org/show_bug.cgi?id=48689">bug 48689</a>
from <span class="vcard"><a class="email" href="mailto:rnk@google.com" title="Reid Kleckner <rnk@google.com>"> <span class="fn">Reid Kleckner</span></a>
</span></b>
<pre>I don't think LLVM_DEBUG does what you want it to. I think you should consider
EXPENSIVE_CHECKS instead.
LLVM_DEBUG is defined here, conditional on NDEBUG, which is what controls
assertions, so LLVM_DEBUG will run in Release+Asserts builds:
<a href="https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/Support/Debug.h#L122">https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm/Support/Debug.h#L122</a>
If I'm reading it correctly, LLVM_DEBUG only runs when the `-debug` LLVM option
is set, and debug output from the relevant pass is enabled. This option is
almost never enabled in the regular test suite, so with LLVM_DEBUG, this
verification function is almost never called.
See also the bug I filed about verifyFunction being too slow:
<a class="bz_bug_link
bz_status_NEW "
title="NEW - verifyFunction spends too much time validating module metadata in +asserts builds"
href="show_bug.cgi?id=47712">https://bugs.llvm.org/show_bug.cgi?id=47712</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>