[llvm-bugs] [Bug 49313] New: relative refstring.h include in libcxxabi makes too strong assumptions

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=49313

            Bug ID: 49313
           Summary: relative refstring.h include in libcxxabi makes too
                    strong assumptions
           Product: libc++abi
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: All Bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: nicolasweber at gmx.de
                CC: llvm-bugs at lists.llvm.org, mclow.lists at gmail.com

a7b65741441556d295079fc4f2391d99fd1c1111 (unreviewed? at least doesn't link to
phab) adds this line to libc++abi's libcxxabi/src/stdlib_stdexcept.cpp:

+#include "../../libcxx/src/include/refstring.h"

This assumes a certain relative layout, which happens to not be the layout we
have libc++ and libc++abi relative to in chromium. It's also not very easy to
change things to give them that layout -- many third-party directories in
chromium put code in "t_p/depname/src" (via a git submodules like thing) and
then 
put a build file in "t_p/depname".


We're trying to update our libc++abi now that we've successfully updated our
libc++, and this is a problem.

We could add a random -I flag that this relative path resolves against. I'll do
this for now, but it's a bit ugly. Maybe we can find something nicer to do on
this bug.

Options:

- say `#include "refstring.h"` and set up the include path in the build system
- revert the change -- refstring.h has changed exactly once since that change,
and that was likely the change motivating
a7b65741441556d295079fc4f2391d99fd1c1111 . Nothing else in libc++abi includes
libcxx stuff, and that seems like a good thing layering-wise. The duplication
is unfortunate, but maybe less unfortunate than a cyclic dep?h

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20210222/da01a5f8/attachment.html>