<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - relative refstring.h include in libcxxabi makes too strong assumptions"
href="https://bugs.llvm.org/show_bug.cgi?id=49313">49313</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>relative refstring.h include in libcxxabi makes too strong assumptions
</td>
</tr>
<tr>
<th>Product</th>
<td>libc++abi
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>All Bugs
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>nicolasweber@gmx.de
</td>
</tr>
<tr>
<th>CC</th>
<td>llvm-bugs@lists.llvm.org, mclow.lists@gmail.com
</td>
</tr></table>
<p>
<div>
<pre>a7b65741441556d295079fc4f2391d99fd1c1111 (unreviewed? at least doesn't link to
phab) adds this line to libc++abi's libcxxabi/src/stdlib_stdexcept.cpp:
+#include "../../libcxx/src/include/refstring.h"
This assumes a certain relative layout, which happens to not be the layout we
have libc++ and libc++abi relative to in chromium. It's also not very easy to
change things to give them that layout -- many third-party directories in
chromium put code in "t_p/depname/src" (via a git submodules like thing) and
then
put a build file in "t_p/depname".
We're trying to update our libc++abi now that we've successfully updated our
libc++, and this is a problem.
We could add a random -I flag that this relative path resolves against. I'll do
this for now, but it's a bit ugly. Maybe we can find something nicer to do on
this bug.
Options:
- say `#include "refstring.h"` and set up the include path in the build system
- revert the change -- refstring.h has changed exactly once since that change,
and that was likely the change motivating
a7b65741441556d295079fc4f2391d99fd1c1111 . Nothing else in libc++abi includes
libcxx stuff, and that seems like a good thing layering-wise. The duplication
is unfortunate, but maybe less unfortunate than a cyclic dep?h</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>