[llvm-bugs] [Bug 45014] New: interception_type_test fails for Android API >= 24 32-bit

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=45014

            Bug ID: 45014
           Summary: interception_type_test fails for Android API >= 24
                    32-bit
           Product: compiler-rt
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: compiler-rt
          Assignee: unassignedbugs at nondot.org
          Reporter: smeenai at fb.com
                CC: eugeni.stepanov at gmail.com, kcc at google.com,
                    llvm-bugs at lists.llvm.org, mitchphillips at outlook.com,
                    peter at pcc.me.uk

https://github.com/llvm/llvm-project/blob/2c0edbf19c1b0115b944cd017201eaf1f6a832ee/llvm/cmake/modules/HandleLLVMOptions.cmake#L300
sets -D_FILE_OFFSET_BITS=64 for Android when targeting API level >= 24, which
means we get a 64-bit off_t even on 32-bit targets. However, compiler-rt
defines its OFF_T type for 32-bit Android as 32 bits in
https://github.com/llvm/llvm-project/blob/2c0edbf19c1b0115b944cd017201eaf1f6a832ee/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h#L178.
interception_type_test.cpp then unconditionally compares the sizes of off_t and
OFF_T for Android in
https://github.com/llvm/llvm-project/blob/2c0edbf19c1b0115b944cd017201eaf1f6a832ee/compiler-rt/lib/interception/interception_type_test.cpp#L36,
which of course fails.

Should we adjust OFF_T to be 64 bits on Android APIs >= 24?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20200225/d16f440a/attachment.html>