<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - interception_type_test fails for Android API >= 24 32-bit"
href="https://bugs.llvm.org/show_bug.cgi?id=45014">45014</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>interception_type_test fails for Android API >= 24 32-bit
</td>
</tr>
<tr>
<th>Product</th>
<td>compiler-rt
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>PC
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>P
</td>
</tr>
<tr>
<th>Component</th>
<td>compiler-rt
</td>
</tr>
<tr>
<th>Assignee</th>
<td>unassignedbugs@nondot.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>smeenai@fb.com
</td>
</tr>
<tr>
<th>CC</th>
<td>eugeni.stepanov@gmail.com, kcc@google.com, llvm-bugs@lists.llvm.org, mitchphillips@outlook.com, peter@pcc.me.uk
</td>
</tr></table>
<p>
<div>
<pre><a href="https://github.com/llvm/llvm-project/blob/2c0edbf19c1b0115b944cd017201eaf1f6a832ee/llvm/cmake/modules/HandleLLVMOptions.cmake#L300">https://github.com/llvm/llvm-project/blob/2c0edbf19c1b0115b944cd017201eaf1f6a832ee/llvm/cmake/modules/HandleLLVMOptions.cmake#L300</a>
sets -D_FILE_OFFSET_BITS=64 for Android when targeting API level >= 24, which
means we get a 64-bit off_t even on 32-bit targets. However, compiler-rt
defines its OFF_T type for 32-bit Android as 32 bits in
<a href="https://github.com/llvm/llvm-project/blob/2c0edbf19c1b0115b944cd017201eaf1f6a832ee/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h#L178">https://github.com/llvm/llvm-project/blob/2c0edbf19c1b0115b944cd017201eaf1f6a832ee/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h#L178</a>.
interception_type_test.cpp then unconditionally compares the sizes of off_t and
OFF_T for Android in
<a href="https://github.com/llvm/llvm-project/blob/2c0edbf19c1b0115b944cd017201eaf1f6a832ee/compiler-rt/lib/interception/interception_type_test.cpp#L36">https://github.com/llvm/llvm-project/blob/2c0edbf19c1b0115b944cd017201eaf1f6a832ee/compiler-rt/lib/interception/interception_type_test.cpp#L36</a>,
which of course fails.
Should we adjust OFF_T to be 64 bits on Android APIs >= 24?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>