[llvm-bugs] [Bug 45459] New: llvm/test/Other/opt-bisect-legacy-pass-manager.ll problems

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=45459

            Bug ID: 45459
           Summary: llvm/test/Other/opt-bisect-legacy-pass-manager.ll
                    problems
           Product: libraries
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: Core LLVM classes
          Assignee: unassignedbugs at nondot.org
          Reporter: paul_robinson at playstation.sony.com
                CC: llvm-bugs at lists.llvm.org

At some point I had noticed the following lines in this test:

; CHECK-BISECT-INLINE-HELPER: call i32 @f2()
; These checks verifies that the optimization was found.
; CHECK-BISECT-INLINE-RESULT-NOT: Last good count: 0
; CHECK-BISECT-INLINE-RESULT: Last good count: {{[0-9]+}}

Because the last line will match "Last good count: 0" the previous -NOT line
would never find that line.  So in 210f40f I changed it to:

; CHECK-BISECT-INLINE-HELPER: call i32 @f2()
; These checks verifies that the optimization was found.
; CHECK-BISECT-INLINE-RESULT: Last good count: {{[1-9][0-9]*}}

which will correctly fail to match "Last good count: 0"

Then David Zarzycki <dave at znu.io> reported it caused a failure in his
environment, although I don't have specific details about that environment.
And Petr Hosek <phosek at chromium.org> reported that it failed for Chromium,
speculating it was because Chromium has the new pass manager by default.

David reverted my change in 74ab5d9, and as I'm looking at this from the
perspective of "clean up poor uses of FileCheck" rather than "get this
test in particular to work" I'm not going to pursue it any further.

But the test clearly needs a bit of help to work as desired in these other
environments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20200407/b097b6c2/attachment.html>