<html>
    <head>
      <base href="https://bugs.llvm.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - llvm/test/Other/opt-bisect-legacy-pass-manager.ll problems"
   href="https://bugs.llvm.org/show_bug.cgi?id=45459">45459</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>llvm/test/Other/opt-bisect-legacy-pass-manager.ll problems
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>libraries
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>trunk
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Core LLVM classes
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>unassignedbugs@nondot.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>paul_robinson@playstation.sony.com
          </td>
        </tr>

        <tr>
          <th>CC</th>
          <td>llvm-bugs@lists.llvm.org
          </td>
        </tr></table>
      <p>
        <div>
        <pre>At some point I had noticed the following lines in this test:

; CHECK-BISECT-INLINE-HELPER: call i32 @f2()
; These checks verifies that the optimization was found.
; CHECK-BISECT-INLINE-RESULT-NOT: Last good count: 0
; CHECK-BISECT-INLINE-RESULT: Last good count: {{[0-9]+}}

Because the last line will match "Last good count: 0" the previous -NOT line
would never find that line.  So in 210f40f I changed it to:

; CHECK-BISECT-INLINE-HELPER: call i32 @f2()
; These checks verifies that the optimization was found.
; CHECK-BISECT-INLINE-RESULT: Last good count: {{[1-9][0-9]*}}

which will correctly fail to match "Last good count: 0"

Then David Zarzycki <<a href="mailto:dave@znu.io">dave@znu.io</a>> reported it caused a failure in his
environment, although I don't have specific details about that environment.
And Petr Hosek <<a href="mailto:phosek@chromium.org">phosek@chromium.org</a>> reported that it failed for Chromium,
speculating it was because Chromium has the new pass manager by default.

David reverted my change in 74ab5d9, and as I'm looking at this from the
perspective of "clean up poor uses of FileCheck" rather than "get this
test in particular to work" I'm not going to pursue it any further.

But the test clearly needs a bit of help to work as desired in these other
environments.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are on the CC list for the bug.</li>
      </ul>
    </body>
</html>