[llvm-bugs] [Bug 42946] gvn-hoist crashes: Assertion `MSSA->dominates(NewDef, FirstDef) && "Should have dominated the new access"' failed.

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=42946

bjorn.a.pettersson at ericsson.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
 Fixed By Commit(s)|                            |r372138
                 CC|                            |alina.sbirlea at gmail.com

--- Comment #1 from bjorn.a.pettersson at ericsson.com ---
I see the assertion failure with r372137, but not with r372138 (and later). I'm
currently at r372709. So I think we can assume that r372138 resolves this PR.

Commit msg says:

commit 4e9082ef95db5d760df4cce00a4351fa122176d6 (HEAD)
Author: Alina Sbirlea <asbirlea at google.com>
Date:   Tue Sep 17 16:33:35 2019 +0000

    [MemorySSA] Fix phi insertion when inserting a def.

    Summary:
    When inserting a Def, the current algorithm is walking edges backward
    and inserting new Phis where needed. There may be additional Phis needed
    in the IDF of the newly inserted Def and Phis.
    Adding Phis in the IDF of the Def was added ina  previous patch, but we
    may also need other Phis in the IDF of the newly added Phis.

    Reviewers: george.burgess.iv

    Subscribers: Prazek, sanjoy.google, llvm-commits

    Tags: #llvm

    Differential Revision: https://reviews.llvm.org/D67637

    llvm-svn: 372138



Thanks Alina!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20190924/2262d153/attachment-0001.html>