<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:bjorn.a.pettersson@ericsson.com" title="bjorn.a.pettersson@ericsson.com">bjorn.a.pettersson@ericsson.com</a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - gvn-hoist crashes: Assertion `MSSA->dominates(NewDef, FirstDef) && "Should have dominated the new access"' failed."
href="https://bugs.llvm.org/show_bug.cgi?id=42946">bug 42946</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">Fixed By Commit(s)</td>
<td>
</td>
<td>r372138
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>alina.sbirlea@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - gvn-hoist crashes: Assertion `MSSA->dominates(NewDef, FirstDef) && "Should have dominated the new access"' failed."
href="https://bugs.llvm.org/show_bug.cgi?id=42946#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - gvn-hoist crashes: Assertion `MSSA->dominates(NewDef, FirstDef) && "Should have dominated the new access"' failed."
href="https://bugs.llvm.org/show_bug.cgi?id=42946">bug 42946</a>
from <span class="vcard"><a class="email" href="mailto:bjorn.a.pettersson@ericsson.com" title="bjorn.a.pettersson@ericsson.com">bjorn.a.pettersson@ericsson.com</a>
</span></b>
<pre>I see the assertion failure with r372137, but not with r372138 (and later). I'm
currently at r372709. So I think we can assume that r372138 resolves this PR.
Commit msg says:
commit 4e9082ef95db5d760df4cce00a4351fa122176d6 (HEAD)
Author: Alina Sbirlea <<a href="mailto:asbirlea@google.com">asbirlea@google.com</a>>
Date: Tue Sep 17 16:33:35 2019 +0000
[MemorySSA] Fix phi insertion when inserting a def.
Summary:
When inserting a Def, the current algorithm is walking edges backward
and inserting new Phis where needed. There may be additional Phis needed
in the IDF of the newly inserted Def and Phis.
Adding Phis in the IDF of the Def was added ina previous patch, but we
may also need other Phis in the IDF of the newly added Phis.
Reviewers: george.burgess.iv
Subscribers: Prazek, sanjoy.google, llvm-commits
Tags: #llvm
Differential Revision: <a href="https://reviews.llvm.org/D67637">https://reviews.llvm.org/D67637</a>
llvm-svn: 372138
Thanks Alina!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>