[llvm-bugs] [Bug 42645] New: [Clang/Format] Don't use Style.isCpp() to check for attribute specifier availability

via llvm-bugs llvm-bugs at lists.llvm.org
Tue Jul 16 14:30:55 PDT 2019


https://bugs.llvm.org/show_bug.cgi?id=42645

            Bug ID: 42645
           Summary: [Clang/Format] Don't use Style.isCpp() to check for
                    attribute specifier availability
           Product: clang
           Version: trunk
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Formatter
          Assignee: unassignedclangbugs at nondot.org
          Reporter: bhamiltoncx at gmail.com
                CC: djasper at google.com, klimek at google.com,
                    llvm-bugs at lists.llvm.org

As pointed out by aaron.ballman in review of D64632:

https://reviews.llvm.org/D64632#1582859

> Clang has a feature flag to enable support for double-square bracket attributes in more than just C++ mode, and this is enabled by default in C2x mode. This check for isCpp() makes me suspect we may be doing the wrong thing here.

TokenAnnotator.cpp should be fixed to use this feature flag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20190716/a3c67770/attachment-0001.html>


More information about the llvm-bugs mailing list