[llvm-bugs] [Bug 43160] [argpromotion] removes "this" from x86_thiscallcc

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=43160

Reid Kleckner <rnk at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #4 from Reid Kleckner <rnk at google.com> ---
Yes, but argument promotion already has the same special case for this:

promoteArguments...
...
  // Don't transform functions that receive inallocas, as the transformation
may
  // not be safe depending on calling convention.
  if (F->getAttributes().hasAttrSomewhere(Attribute::InAlloca))
    return nullptr;

And it looks like that code was added in r359743, which is after 8.0. So, it
looks like this was found and fixed.

---

Globalopt already tries to apply fastcc when it can, as you've noticed, so I
don't think there's anything else to fix with regards to thiscall functions
that don't use inalloca.

*** This bug has been marked as a duplicate of bug 41658 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20190829/6a7b9774/attachment-0001.html>