<html>
<head>
<base href="https://bugs.llvm.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:rnk@google.com" title="Reid Kleckner <rnk@google.com>"> <span class="fn">Reid Kleckner</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED DUPLICATE - [argpromotion] removes "this" from x86_thiscallcc"
href="https://bugs.llvm.org/show_bug.cgi?id=43160">bug 43160</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>DUPLICATE
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED DUPLICATE - [argpromotion] removes "this" from x86_thiscallcc"
href="https://bugs.llvm.org/show_bug.cgi?id=43160#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED DUPLICATE - [argpromotion] removes "this" from x86_thiscallcc"
href="https://bugs.llvm.org/show_bug.cgi?id=43160">bug 43160</a>
from <span class="vcard"><a class="email" href="mailto:rnk@google.com" title="Reid Kleckner <rnk@google.com>"> <span class="fn">Reid Kleckner</span></a>
</span></b>
<pre>Yes, but argument promotion already has the same special case for this:
promoteArguments...
...
// Don't transform functions that receive inallocas, as the transformation
may
// not be safe depending on calling convention.
if (F->getAttributes().hasAttrSomewhere(Attribute::InAlloca))
return nullptr;
And it looks like that code was added in r359743, which is after 8.0. So, it
looks like this was found and fixed.
---
Globalopt already tries to apply fastcc when it can, as you've noticed, so I
don't think there's anything else to fix with regards to thiscall functions
that don't use inalloca.
*** This bug has been marked as a duplicate of <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - "cannot use inalloca attribute on a register parameter" after argpromoting x86_thiscallcc"
href="show_bug.cgi?id=41658">bug 41658</a> ***</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>