[llvm-branch-commits] [clang] [llvm] Add format string handling (PR #196568)

[Abhina Sree via llvm-branch-commits]

abhina-sree wrote:

Copying the comment from the last PR from @s-barannikov 
> May it make sense to introduce a strong typedef for a "target" character and use it in format string parsing? This would help find all the places where we need to convert the "target" character to "internal" encoding. It would also make the intent more clear.

I'm not sure if this works. I tried implementing this, but it seems to offer little benefit, because although we are doing comparisons with the reverse-translated character, we are still using the original character after those comparisons. So it would not catch any missing conversions, unless there is a way to implement this that does catch the missing conversions

https://github.com/llvm/llvm-project/pull/196568