[llvm-branch-commits] [libcxx] [libc++][string] Improve constexpr efficiency (PR #184724)

[Louis Dionne via llvm-branch-commits]

https://github.com/ldionne requested changes to this pull request.

Similarly to my comment in https://github.com/llvm/llvm-project/pull/184723#pullrequestreview-4528083757, I don't think we should move forward with this patch. I don't think it makes sense to try moving from one arbitrary point to another arbitrary point. There are implementation limits (which can be changed), if the defaults don't work for your use case, they are meant to be increased.

If at all, I would argue this could be taken as a request to (yet again) increase the limit in Clang. But I don't think it makes sense for libc++ to start trying to provide guarantees here.

https://github.com/llvm/llvm-project/pull/184724