[llvm-branch-commits] [llvm] [Dexter] Add additional variable metrics, sanitize lldb-dap function names (PR #204366)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Jun 17 08:17:53 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r origin/main...HEAD cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py cross-project-tests/debuginfo-tests/dexter/dex/evaluation/Metrics.py
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- debugger/lldb/LLDB.py	2026-06-17 14:59:04.000000 +0000
+++ debugger/lldb/LLDB.py	2026-06-17 15:07:04.975237 +0000
@@ -436,11 +436,11 @@
             "_start",
         ]
 
     def _sanitize_function_name(self, name: str):  # pylint: disable=no-self-use
         if name.endswith(" [opt]"):
-            name = name[:-len(" [opt]")]
+            name = name[: -len(" [opt]")]
         return name
 
     def _post_step_hook(self):
         """Hook to be executed after completing a step request."""
         if self._debugger_state.stopped_reason == "step":
--- evaluation/Metrics.py	2026-06-17 14:59:04.000000 +0000
+++ evaluation/Metrics.py	2026-06-17 15:07:05.068091 +0000
@@ -149,13 +149,17 @@
             num_total_steps - num_correct_steps, improves_asc=False
         ),
         # The sum of the 0.0-1.0 "correctness value" of matches across each step.
         "partial_step_correctness": ScalarMetric(partial_step_correctness),
         # The number of steps where the watched variable/expression was marked "optimized out" in the debugger.
-        "optimized_out_steps": ScalarMetric(num_optimized_out_steps, improves_asc=False),
+        "optimized_out_steps": ScalarMetric(
+            num_optimized_out_steps, improves_asc=False
+        ),
         # The number of steps where the watched variable/expression had an inaccessible address in the debugger.
-        "irretrievable_steps": ScalarMetric(num_irretrievable_steps, improves_asc=False),
+        "irretrievable_steps": ScalarMetric(
+            num_irretrievable_steps, improves_asc=False
+        ),
         # The number of steps where the watched variable/expression was not available in the debugger.
         "missing_var_steps": ScalarMetric(num_missing_var_steps, improves_asc=False),
         # The number of steps where the watched variable/expression had a value not in the set of expected values.
         f"unexpected_{kind_string}_steps": ScalarMetric(
             num_unexpected_value_steps, improves_asc=False

``````````

</details>


https://github.com/llvm/llvm-project/pull/204366


More information about the llvm-branch-commits mailing list