[llvm-branch-commits] [llvm] [AMDGPU][InsertWaitCnts] Make HWEvent a BitMask (PR #203864)

Fabian Ritter via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Jun 15 07:56:16 PDT 2026


================
@@ -19,110 +23,108 @@ class raw_ostream;
 
 namespace AMDGPU {
 
-/// TODO: This should be a bitmask from the start instead of having this enum
-///       + \ref HWEventSet below.
-enum class HWEvent : unsigned char {
-#define AMDGPU_HW_EVENT(X) X,
-#define AMDGPU_FIRST_HW_EVENT(X) FIRST_WAIT_EVENT = X,
-#define AMDGPU_LAST_HW_EVENT(X) NUM_WAIT_EVENTS = X,
-#include "AMDGPUHWEvents.def"
-};
-
-} // namespace AMDGPU
+class HWEvent {
----------------
ritter-x2a wrote:

It feels odd to me to have a class called `HWEvent` (i.e., singular), but an instance represents a set of events. Would it make sense to call it `HWEvents` instead?

https://github.com/llvm/llvm-project/pull/203864


More information about the llvm-branch-commits mailing list