[llvm-branch-commits] [flang] [llvm] [flang][OpenMP] Parsing and semantics of locators as part of OmpObject (PR #203910)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- flang/include/flang/Parser/dump-parse-tree.h flang/include/flang/Parser/parse-tree.h flang/include/flang/Semantics/expression.h flang/include/flang/Semantics/symbol.h flang/lib/Lower/OpenMP/ClauseProcessor.cpp flang/lib/Lower/OpenMP/Clauses.cpp flang/lib/Parser/openmp-parsers.cpp flang/lib/Parser/openmp-utils.cpp flang/lib/Parser/unparse.cpp flang/lib/Semantics/check-omp-loop.cpp flang/lib/Semantics/check-omp-structure.cpp flang/lib/Semantics/check-omp-structure.h flang/lib/Semantics/check-omp-variant.cpp flang/lib/Semantics/openmp-utils.cpp flang/lib/Semantics/resolve-directives.cpp flang/lib/Semantics/resolve-names.cpp flang/lib/Semantics/rewrite-parse-tree.cpp llvm/include/llvm/Frontend/OpenMP/OMP.h llvm/lib/Frontend/OpenMP/OMP.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/flang/lib/Lower/OpenMP/Clauses.cpp b/flang/lib/Lower/OpenMP/Clauses.cpp
index 9ab9e9349..66850a709 100644
--- a/flang/lib/Lower/OpenMP/Clauses.cpp
+++ b/flang/lib/Lower/OpenMP/Clauses.cpp
@@ -173,16 +173,15 @@ Object makeObject(const parser::EntityDecl &decl,
 ObjectList makeObjects(const parser::OmpArgumentList &objects,
                        semantics::SemanticsContext &semaCtx) {
   return makeList(objects.v, [&](const parser::OmpArgument &arg) {
-    return common::visit(
-        common::visitors{
-            [&](const parser::OmpObject &object) -> Object {
-              return makeObject(object, semaCtx);
-            },
-            [](auto &&s) -> Object { //
-              llvm_unreachable("Expecting object");
-            },
-        },
-        arg.u);
+    return common::visit(common::visitors{
+                             [&](const parser::OmpObject &object) -> Object {
+                               return makeObject(object, semaCtx);
+                             },
+                             [](auto &&s) -> Object { //
+                               llvm_unreachable("Expecting object");
+                             },
+                         },
+                         arg.u);
   });
 }
 
diff --git a/flang/lib/Parser/openmp-parsers.cpp b/flang/lib/Parser/openmp-parsers.cpp
index a44228f24..fe5c13d35 100644
--- a/flang/lib/Parser/openmp-parsers.cpp
+++ b/flang/lib/Parser/openmp-parsers.cpp
@@ -291,7 +291,8 @@ TYPE_PARSER( //
     construct<OmpReservedIdentifier>(predicated(name, IsReservedName)))
 
 TYPE_PARSER( //
-    // Parse x(...)(...) as a substring instead of a function reference.
+             // Parse x(...)(...) as a substring instead of a function
+             // reference.
     construct<OmpLocator>(functionReference / !lookAhead("("_tok)) ||
     construct<OmpLocator>(Parser<OmpReservedIdentifier>{}))
 
diff --git a/flang/lib/Semantics/openmp-utils.cpp b/flang/lib/Semantics/openmp-utils.cpp
index d5035cbd2..922701606 100644
--- a/flang/lib/Semantics/openmp-utils.cpp
+++ b/flang/lib/Semantics/openmp-utils.cpp
@@ -478,9 +478,7 @@ std::optional<bool> IsContiguous(
             }
             return std::optional<bool>{};
           },
-          [&](const parser::OmpLocator &) {
-            return std::optional<bool>{};
-          },
+          [&](const parser::OmpLocator &) { return std::optional<bool>{}; },
           [&](const parser::OmpObject::Invalid &) {
             return std::optional<bool>{};
           }},

``````````

</details>


https://github.com/llvm/llvm-project/pull/203910