[llvm-branch-commits] [llvm] [LoopInterchange] Use UTC as much as possible (NFC) (PR #202096)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->


:warning: undef deprecator found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef([^a-zA-Z0-9_-]|$)|UndefValue::get)' 'HEAD~1' HEAD llvm/test/Transforms/LoopInterchange/confused-dependence.ll llvm/test/Transforms/LoopInterchange/currentLimitation.ll llvm/test/Transforms/LoopInterchange/debuginfo.ll llvm/test/Transforms/LoopInterchange/force-interchange.ll llvm/test/Transforms/LoopInterchange/fp-reductions.ll llvm/test/Transforms/LoopInterchange/guarded-inner-loop.ll llvm/test/Transforms/LoopInterchange/inner-only-reductions.ll llvm/test/Transforms/LoopInterchange/interchange-insts-between-indvar.ll llvm/test/Transforms/LoopInterchange/legality-for-scalar-deps.ll llvm/test/Transforms/LoopInterchange/loopnest-with-outer-btc0.ll llvm/test/Transforms/LoopInterchange/multilevel-partial-reduction.ll llvm/test/Transforms/LoopInterchange/outer-dependency-lte.ll llvm/test/Transforms/LoopInterchange/outer-only-reductions.ll llvm/test/Transforms/LoopInterchange/pr43176-move-to-new-latch.ll llvm/test/Transforms/LoopInterchange/pr43326-ideal-access-pattern.ll llvm/test/Transforms/LoopInterchange/pr43326.ll llvm/test/Transforms/LoopInterchange/pr48212.ll llvm/test/Transforms/LoopInterchange/profitability-redundant-interchange.ll llvm/test/Transforms/LoopInterchange/profitability-vectorization-heuristic.ll llvm/test/Transforms/LoopInterchange/profitability-vectorization.ll llvm/test/Transforms/LoopInterchange/reductions-across-inner-and-outer-loop.ll llvm/test/Transforms/LoopInterchange/reductions-non-wrapped-operations.ll
``````````

</details>


The following files introduce new uses of undef:
 - llvm/test/Transforms/LoopInterchange/pr43176-move-to-new-latch.ll
 - llvm/test/Transforms/LoopInterchange/pr48212.ll
 - llvm/test/Transforms/LoopInterchange/profitability-vectorization-heuristic.ll

[Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields `undef`. You should use `poison` values for placeholders instead.

In tests, avoid using `undef` and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.

For example, this is considered a bad practice:
```llvm
define void @fn() {
  ...
  br i1 undef, ...
}
```

Please use the following instead:
```llvm
define void @fn(i1 %cond) {
  ...
  br i1 %cond, ...
}
```

Please refer to the [Undefined Behavior Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information.



https://github.com/llvm/llvm-project/pull/202096