[llvm-branch-commits] [llvm] [X86] Remove shouldCastAtomicLoadInIR; use DAG combine instead (PR #199520)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 135361 tests passed
* 3360 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### LLVM
<details>
<summary>LLVM.Transforms/AtomicExpand/X86/expand-atomic-non-integer.ll</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 2
c:\_work\llvm-project\llvm-project\build\bin\opt.exe -S C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll -passes='require<libcall-lowering-info>,atomic-expand' -mtriple=x86_64-linux-gnu | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll --check-prefixes=CHECK,CHECK64
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\opt.exe' -S 'C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll' '-passes=require<libcall-lowering-info>,atomic-expand' -mtriple=x86_64-linux-gnu
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll' --check-prefixes=CHECK,CHECK64
# note: command had no output on stdout or stderr
# RUN: at line 3
c:\_work\llvm-project\llvm-project\build\bin\opt.exe -S C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll -passes='require<libcall-lowering-info>,atomic-expand' -mtriple=i686-linux-gnu | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll --check-prefixes=CHECK,CHECK32
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\opt.exe' -S 'C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll' '-passes=require<libcall-lowering-info>,atomic-expand' -mtriple=i686-linux-gnu
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll' --check-prefixes=CHECK,CHECK32
# note: command had no output on stdout or stderr
# RUN: at line 4
c:\_work\llvm-project\llvm-project\build\bin\opt.exe -S C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll -passes='require<libcall-lowering-info>,atomic-expand' -mtriple=x86_64-linux-gnu -mattr=+cx16,-avx | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll --check-prefixes=CX16
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\opt.exe' -S 'C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll' '-passes=require<libcall-lowering-info>,atomic-expand' -mtriple=x86_64-linux-gnu -mattr=+cx16,-avx
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll' --check-prefixes=CX16
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll:445:14: error: CX16-NEXT: expected string not found in input
# | ; CX16-NEXT: [[TMP1:%.*]] = load atomic i32, ptr [[X]] acquire, align 8
# |              ^
# | <stdin>:139:49: note: scanning from here
# | define <2 x half> @atomic_vec2_half(ptr %x) #1 {
# |                                                 ^
# | <stdin>:139:49: note: with "X" equal to "%x"
# | define <2 x half> @atomic_vec2_half(ptr %x) #1 {
# |                                                 ^
# | <stdin>:140:7: note: possible intended match here
# |  %ret = load atomic <2 x half>, ptr %x acquire, align 8
# |       ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\llvm\test\Transforms\AtomicExpand\X86\expand-atomic-non-integer.ll
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |             .
# |             .
# |             .
# |           134:  %ret = load atomic <2 x i16>, ptr %x acquire, align 8 
# |           135:  ret <2 x i16> %ret 
# |           136: } 
# |           137:  
# |           138: ; Function Attrs: nounwind 
# |           139: define <2 x half> @atomic_vec2_half(ptr %x) #1 { 
# | next:445'0                                                     X error: no match found
# | next:445'1                                                       with "X" equal to "%x"
# |           140:  %ret = load atomic <2 x half>, ptr %x acquire, align 8 
# | next:445'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | next:445'2           ?                                                  possible intended match
# |           141:  ret <2 x half> %ret 
# | next:445'0     ~~~~~~~~~~~~~~~~~~~~~
# |           142: } 
# | next:445'0     ~~
# |           143:  
# | next:445'0     ~
# |           144: ; Function Attrs: nounwind 
# | next:445'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           145: define <4 x i32> @atomic_vec4_i32(ptr %x) #1 { 
# | next:445'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |             .
# |             .
# |             .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/199520