[llvm-branch-commits] [clang] [KeyInstr][Clang] Assignment atom group (PR #134637)

[Orlando Cazalet-Hyams via llvm-branch-commits]

================
@@ -5849,6 +5852,7 @@ LValue CodeGenFunction::EmitObjCIsaExpr(const ObjCIsaExpr *E) {
 
 LValue CodeGenFunction::EmitCompoundAssignmentLValue(
                                             const CompoundAssignOperator *E) {
+  ApplyAtomGroup Grp(getDebugInfo());
----------------
OCHyams wrote:

> If I enter via a VisitBin##OP##Assign function from above I'll get an atom group before calling EmitCompoundAssign,

Looks correct

> then get a second atom group here in EmitcompoundAssignmentLValue (which is called by EmitCompoundAssign). I would have expected only one atom group to be generated in that, is that wrong?

Looks wrong - `EmitCompoundAssign` calls `EmitCompoundAssignLValue` not `EmitcompoundAssignmentLValue`. The function names are annoyingly similar, this took a bit of head-scratching to re-figure out!

https://github.com/llvm/llvm-project/pull/134637