[llvm-branch-commits] [clang] [KeyInstr][Clang] Assignment atom group (PR #134637)

[Orlando Cazalet-Hyams via llvm-branch-commits]

================
@@ -5985,6 +5985,15 @@ LValue CodeGenFunction::EmitBinaryOperatorLValue(const BinaryOperator *E) {
 
   assert(E->getOpcode() == BO_Assign && "unexpected binary l-value");
 
+  // This covers both LHS and RHS expressions, though nested RHS
+  // expressions may get subsequently separately grouped.
+  // FIXME(OCH): Not clear yet if we've got fine enough control
+  // to pick and choose when we need to. Currently looks ok:
+  // a = b = c  -> Two atoms.
+  // x = new(1) -> One atom (for both addr store and value store).
----------------
OCHyams wrote:

I was thinking out loud, I guess. Agree it doesn't really add anything (except confusion) so I've removed it.

https://github.com/llvm/llvm-project/pull/134637