[llvm-branch-commits] [llvm] [BOLT] Gadget scanner: Detect address materialization and arithmetics (PR #132540)

[Kristof Beyls via llvm-branch-commits]

================
@@ -587,6 +587,22 @@ class MCPlusBuilder {
     return getNoRegister();
   }
 
+  virtual MCPhysReg getSafelyMaterializedAddressReg(const MCInst &Inst) const {
+    llvm_unreachable("not implemented");
+    return getNoRegister();
+  }
----------------
kbeyls wrote:

I think that "safely materialized address register" is not a common term and different people seeing it are likely to have somewhat different guesses at what it might mean.
Therefore, this method probably needs a comment that explains what a "safely materialized address register" is.

https://github.com/llvm/llvm-project/pull/132540