[llvm-branch-commits] [clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support AMDGPU's generic target (PR #122629)

Shilei Tian via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jan 14 09:50:40 PST 2025


shiltian wrote:

First of all, I don't think it can fix the issue in a robust way. Second, `generic` is already a valid target/cpu/offload target.

Unless we do something like, if the last part is `generic`, we keep looking forward until we can construct a valid target. That has no difference than doing pattern matching, which is back to my previous point about AMD special sauce.

If we assert that the offload bundler is an AMD only thing (which TBH really looks like so), I'm fine with adding a bunch of more special sauce here.

https://github.com/llvm/llvm-project/pull/122629


More information about the llvm-branch-commits mailing list