[llvm-branch-commits] [clang] [llvm] [OffloadBundler] Rework the ctor of `OffloadTargetInfo` to support AMDGPU's generic target (PR #122629)

Yaxun Liu via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jan 14 09:23:33 PST 2025


yxsamliu wrote:

> Somewhere for the linker wrapper I just checked if the triple was recognized, you could probably just take strings after the `-` until it stops working.

+1

It would be bad user experience to break existing app. It would be low risk to have env+cpu to be a valid cpu. So you could assume env exist first, if fails to parse remaining as cpu, then recoil to assume no env and parse the remaining all as cpu.

https://github.com/llvm/llvm-project/pull/122629


More information about the llvm-branch-commits mailing list