[llvm-branch-commits] [clang] [Serialization] No transitive identifier change (PR #92085)

[Jan Svoboda via llvm-branch-commits]

================
@@ -3896,7 +3903,7 @@ void ASTWriter::WriteIdentifierTable(Preprocessor &PP,
 
       // Write out identifiers if either the ID is local or the identifier has
       // changed since it was loaded.
-      if (ID >= FirstIdentID || !Chain || !II->isFromAST() ||
+      if (isLocalIdentifierID(ID) || !Chain || !II->isFromAST() ||
----------------
jansvoboda11 wrote:

This diff makes it seem that `ID >= FirstIdentID` is equivalent to `isLocalIdentifierID(ID)`, which I don't think is the case. Can you explain what's going on here?

https://github.com/llvm/llvm-project/pull/92085