[llvm-branch-commits] [clang] [Serialization] No transitive identifier change (PR #92085)

Jan Svoboda via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri May 24 05:12:23 PDT 2024


================
@@ -918,7 +918,7 @@ ASTSelectorLookupTrait::ReadKey(const unsigned char* d, unsigned) {
   SelectorTable &SelTable = Reader.getContext().Selectors;
   unsigned N = endian::readNext<uint16_t, llvm::endianness::little>(d);
   const IdentifierInfo *FirstII = Reader.getLocalIdentifier(
-      F, endian::readNext<uint32_t, llvm::endianness::little>(d));
+      F, endian::readNext<IdentifierID, llvm::endianness::little>(d));
----------------
jansvoboda11 wrote:

I think having some kind of `static_assert` that `IdentifierID` is an integral type would be helpful. Maybe that'd be useful even within `endian::readNext()`?

https://github.com/llvm/llvm-project/pull/92085


More information about the llvm-branch-commits mailing list