[llvm-branch-commits] [llvm] [BOLT] Ignore hot markers as function references in updateELFSymbolTable (PR #92713)

Amir Ayupov via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sun May 19 20:05:25 PDT 2024


================
@@ -30,12 +31,12 @@
 # CHECK-OUTPUT:       __hot_start
 # CHECK-OUTPUT-NEXT:  main
 # CHECK-OUTPUT-NEXT:  __hot_end
+# CHECK-OUTPUT-NOT:   __hot_start.cold
 
   .text
   .globl  main
   .type main, %function
   .globl  __hot_start
-  .type __hot_start, %object
----------------
aaupov wrote:

If __hot_start has `%object` type, it will be an absolute symbol and won't belong to .text section. When updating function symbols, we check that symbol section matches that of the function. So we need hot_start to be a global symbol in `.text` section.

https://github.com/llvm/llvm-project/pull/92713


More information about the llvm-branch-commits mailing list