[llvm-branch-commits] [llvm] [BOLT] Ignore hot markers as function references in updateELFSymbolTable (PR #92713)

Amir Ayupov via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sun May 19 19:57:04 PDT 2024


================
@@ -4788,13 +4788,22 @@ void RewriteInstance::updateELFSymbolTable(
     if (!IsDynSym && shouldStrip(Symbol))
       continue;
 
+    Expected<StringRef> SymbolName = Symbol.getName(StringSection);
+    assert(SymbolName && "cannot get symbol name");
----------------
aaupov wrote:

Not really. Let me drop it. Yes, Expected will blow up upon null access, and the assertion message is not more insightful than SymbolName variable itself.

https://github.com/llvm/llvm-project/pull/92713


More information about the llvm-branch-commits mailing list