[llvm-branch-commits] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #96265)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Jun 21 08:39:09 PDT 2024


================

----------------
agozillon wrote:

Hi, I believe in this case it is at the point of being minimal, I could reduce it to 1 of the 4 test cases if you wish keeping the most complicated or if you have any other suggestions on how to reduce it I would be more than happy to adjust the test. 

The test is checking the correct information is accessed and inserted into the OpenMP map information construct so it unfortunately requires a number of CHECK's, most of the code gen is handled via OpenMPToLLVMIRTranslation.cpp and the OMPIRBuilder.cpp (although it is of course susceptible to modifications in the MLIR -> LLVM-IR lowering and LLVM changes like most other tests). The MLIR itself requires a number of omp.map.info operations to test it, with a somewhat sane approximation of what it would expect as an argument (in this case accesses into a larger structure). The bounds aren't entirely necessary for the example though (mainly just checking the array offsets work in conjunction with everything still), so I could remove them if you wish which might lower the number of constants as well?

https://github.com/llvm/llvm-project/pull/96265


More information about the llvm-branch-commits mailing list