[llvm-branch-commits] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #96265)
Christian Ulmann via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Fri Jun 21 01:10:08 PDT 2024
================
----------------
Dinistro wrote:
Please reduce this test to the absolute minimum that still tests your change. The IR does not need to compute anything useful, but the test should fail when you would revert only your C++ changes.
Additionally, try to reduce the `CHECK`s to a minimum to not make the test exceptionally sensitive to all kinds of changes.
https://github.com/llvm/llvm-project/pull/96265
More information about the llvm-branch-commits
mailing list