[llvm-branch-commits] [llvm] [DirectX] Make DXILOpBuilder's API more useable (PR #101250)

[S. Bharadwaj Yadavalli via llvm-branch-commits]

https://github.com/bharadwajy commented:

I do not see the invocation of any of the newly created functions in `class DXILOpbuilder` specific to DXIL Ops `create##Name##Op(...)` or `tryCreate##Name##Op(...)` (for example `createSinSin13()` or `tryCreateSin13()` when lowering `llvm.sin.*`). Are these in preparation for upcoming changes?

It appears that macro defs `DXIL_OPCODE` are generated in `DXILEmitter` with its definition is in `DXILOpBuilder.h`. Would you consider generating the `tryCreate<Name><Code>(...)` and `create<Name><Code>(...)` for each of DXIL Ops in `DXILEmitter`, instead, to keep the entire function generation functionality in a single place i.e., `DXILEmitter`?  

https://github.com/llvm/llvm-project/pull/101250