[llvm-branch-commits] [llvm] [DirectX] Make DXILOpBuilder's API more useable (PR #101250)

Damyan Pepper via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jul 30 18:23:49 PDT 2024


================
@@ -289,24 +289,25 @@ static ShaderKind getShaderKindEnum(Triple::EnvironmentType EnvType) {
 ///               its specification in DXIL.td.
 /// \param OverloadTy Return type to be used to construct DXIL function type.
----------------
damyanp wrote:

The doxygen comment about getDxilOpFunctionType is now out of date.

I'm not sure that the list of parameters in the comment is really adding much, but I think the mismatch would generate a Doxygen warning so it'd be worth resolving this one way or another.

https://github.com/llvm/llvm-project/pull/101250


More information about the llvm-branch-commits mailing list