[llvm-branch-commits] [llvm] [DirectX] Make DXILOpBuilder's API more useable (PR #101250)
Justin Bogner via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Tue Jul 30 15:56:44 PDT 2024
https://github.com/bogner updated https://github.com/llvm/llvm-project/pull/101250
>From bb8ed818abc30065713e9a21863624ad9b6c4820 Mon Sep 17 00:00:00 2001
From: Justin Bogner <mail at justinbogner.com>
Date: Tue, 30 Jul 2024 15:56:35 -0700
Subject: [PATCH] Improve comment
Created using spr 1.3.5-bogner
---
llvm/utils/TableGen/DXILEmitter.cpp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/llvm/utils/TableGen/DXILEmitter.cpp b/llvm/utils/TableGen/DXILEmitter.cpp
index 0c2b9ec69d82e..66b6206fedea5 100644
--- a/llvm/utils/TableGen/DXILEmitter.cpp
+++ b/llvm/utils/TableGen/DXILEmitter.cpp
@@ -151,9 +151,10 @@ DXILOperationDesc::DXILOperationDesc(const Record *R) {
assert(knownType && "Specification of multiple differing overload "
"parameter types not yet supported");
} else {
- // Skip the return value - nothing is overloaded on only return, and it
- // makes it harder to determine the overload from an argument list
- // later.
+ // Skip the return value - having the overload index point at the return
+ // value makes it hard to determine the overload from an argument list,
+ // and we treat unoverloaded functions and those overloaded on return
+ // identically anyway.
if (i != 0)
OverloadParamIndices.push_back(i);
}
More information about the llvm-branch-commits
mailing list