[llvm-branch-commits] [clang] [llvm] [LLVM][PassBuilder] Extend the function signature of callback for optimizer pipeline extension point (PR #100953)

Shilei Tian via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Jul 29 06:25:27 PDT 2024


shiltian wrote:

> This seems fine to me in general. The patch stack seems to be messed up though, or at least this seems to contain some unrelated AMDGPU changes.

It has some AMD changes because I'd like to demonstrate how the changes will be used.

> The other thing I wonder about is whether this argument should be added to other callbacks as well for consistency.

Yeah, I was wondering that as well. I'm happy to do the changes but not sure if that's necessary.

https://github.com/llvm/llvm-project/pull/100953


More information about the llvm-branch-commits mailing list