[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

[via llvm-branch-commits]

================
@@ -45,6 +45,8 @@ namespace opts {
 
 extern cl::opt<bool> TimeRewrite;
 extern cl::OptionCategory BoltOptCategory;
+extern cl::opt<unsigned> Verbosity;
+extern cl::opt<bool> ProfileUsePseudoProbes;
----------------
WenleiHe wrote:

> There's no use of probes outside stale matching. 

True, but you do have the options to let probe live in yaml profile and then not use it (even just for testing). you do have a state this is NOT "having probe and use it for profile matching". 

Wouldn't a switch like `enable-probe-based-profile-matching` reflect the intention much better? We may even need something like `profile-matching-strategy={probe,hash,call}` in the future. 

> It's as if we had ProfileEmitDFSIndices and ProfileAssumeDFSIndices instead of ProfileUseDFS which covers both.

This is different, DFS order is a property of the profile. Whether you use probe to do matching is not. 

https://github.com/llvm/llvm-project/pull/99891